Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java

Issue 1263573004: Move NTP related classes to ntp package. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: newt's nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/LogoBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java
similarity index 87%
rename from chrome/android/java/src/org/chromium/chrome/browser/LogoBridge.java
rename to chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java
index becdeaa0cb5d80a072e9fe13c59b06ee61686328..341e637a35ad9fb83b44b54ce18d47d3aacaaaa3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/LogoBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.chrome.browser;
+package org.chromium.chrome.browser.ntp;
import android.graphics.Bitmap;
@@ -12,12 +12,12 @@ import org.chromium.chrome.browser.profiles.Profile;
/**
* Provides access to the search provider's logo via the C++ LogoService.
*/
-public class LogoBridge {
+class LogoBridge {
/**
* A logo for a search provider (e.g. the Yahoo! logo or Google doodle).
*/
- public static class Logo {
+ static class Logo {
/**
* The logo image. Non-null.
*/
@@ -33,7 +33,7 @@ public class LogoBridge {
*/
public final String altText;
- public Logo(Bitmap image, String onClickUrl, String altText) {
+ Logo(Bitmap image, String onClickUrl, String altText) {
this.image = image;
this.onClickUrl = onClickUrl;
this.altText = altText;
@@ -43,7 +43,7 @@ public class LogoBridge {
/**
* Observer for receiving the logo when it's available.
*/
- public interface LogoObserver {
+ interface LogoObserver {
/**
* Called when the cached or fresh logo is available. This may be called up to two times,
* once with the cached logo and once with a freshly downloaded logo.
@@ -52,7 +52,7 @@ public class LogoBridge {
* @param fromCache Whether the logo was loaded from the cache.
*/
@CalledByNative("LogoObserver")
- public void onLogoAvailable(Logo logo, boolean fromCache);
+ void onLogoAvailable(Logo logo, boolean fromCache);
}
private long mNativeLogoBridge;
@@ -62,7 +62,7 @@ public class LogoBridge {
*
* @param profile Profile of the tab that will show the logo.
*/
- public LogoBridge(Profile profile) {
+ LogoBridge(Profile profile) {
mNativeLogoBridge = nativeInit(profile);
}
@@ -70,7 +70,7 @@ public class LogoBridge {
* Cleans up the C++ side of this class. After calling this, LogoObservers passed to
* getCurrentLogo() will no longer receive updates.
*/
- public void destroy() {
+ void destroy() {
assert mNativeLogoBridge != 0;
nativeDestroy(mNativeLogoBridge);
mNativeLogoBridge = 0;
@@ -83,7 +83,7 @@ public class LogoBridge {
* available. logoObserver.onLogoAvailable() may be called synchronously if
* the cached logo is already available.
*/
- public void getCurrentLogo(LogoObserver logoObserver) {
+ void getCurrentLogo(LogoObserver logoObserver) {
nativeGetCurrentLogo(mNativeLogoBridge, logoObserver);
}

Powered by Google App Engine
This is Rietveld 408576698