Issue 12618009: Move SystemIndicator parsing out of Extension class

Issue 12618009: Move SystemIndicator parsing out of Extension class (Closed)

Created:
7 years, 9 months ago by Devlin

Modified:
7 years, 9 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move SystemIndicator parsing out of Extension class TBR=ben@chromium.org, mirandac@chromium.org (ben - gypis, mirandac - profiles) BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190455

Patch Set 3 : Latest master for CQ #

Patch Set 4 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+321 lines, -235 lines)			Patch
M	chrome/browser/extensions/api/system_indicator/system_indicator_api.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/system_indicator/system_indicator_api.cc	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_action_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_dependency_manager.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_action/action_info.h	View	1	4 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_action/action_info.cc	View	1	2 chunks	+156 lines, -9 lines	0 comments	Download
M	chrome/common/extensions/api/extension_action/browser_action_handler.cc	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/api/extension_action/page_action_handler.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/common/extensions/api/extension_action/script_badge_handler.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/common/extensions/api/page_launcher/page_launcher_handler.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
A	chrome/common/extensions/api/system_indicator/system_indicator_handler.h	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/api/system_indicator/system_indicator_handler.cc	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 2 3	5 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2 3	4 chunks	+4 lines, -49 lines	0 comments	Download
M	chrome/common/extensions/manifest_handler_helpers.h	View		2 chunks	+2 lines, -14 lines	0 comments	Download
M	chrome/common/extensions/manifest_handler_helpers.cc	View		2 chunks	+0 lines, -136 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM https://codereview.chromium.org/12618009/diff/2001/chrome/common/extensions/api/extension_action/action_info.cc File chrome/common/extensions/api/extension_action/action_info.cc (right): https://codereview.chromium.org/12618009/diff/2001/chrome/common/extensions/api/extension_action/action_info.cc#newcode16 chrome/common/extensions/api/extension_action/action_info.cc:16: namespace keys = extension_manifest_keys; You can use these ...

7 years, 9 months ago (2013-03-21 00:07:50 UTC) #2

Devlin

https://codereview.chromium.org/12618009/diff/2001/chrome/common/extensions/api/extension_action/action_info.cc File chrome/common/extensions/api/extension_action/action_info.cc (right): https://codereview.chromium.org/12618009/diff/2001/chrome/common/extensions/api/extension_action/action_info.cc#newcode16 chrome/common/extensions/api/extension_action/action_info.cc:16: namespace keys = extension_manifest_keys; On 2013/03/21 00:07:50, Yoyo Zhou ...

7 years, 9 months ago (2013-03-23 22:23:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/12618009/22001

7 years, 9 months ago (2013-03-24 18:29:12 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 9 months ago (2013-03-24 19:46:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/12618009/34001

7 years, 9 months ago (2013-03-25 16:25:04 UTC) #6

Message was sent while issue was closed.

Change committed as 190455

Expand Messages | Collapse Messages