Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/common/extensions/manifest_handler_helpers.h

Issue 12618009: Move SystemIndicator parsing out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/manifest_handler_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_handler_helpers.h
diff --git a/chrome/common/extensions/manifest_handler_helpers.h b/chrome/common/extensions/manifest_handler_helpers.h
index 15743479125da4fc71a44bb4aa53ae0eced2b51b..0abd0d682a6852e829fefb56919ac5e79abebc8c 100644
--- a/chrome/common/extensions/manifest_handler_helpers.h
+++ b/chrome/common/extensions/manifest_handler_helpers.h
@@ -10,17 +10,13 @@
#include "base/memory/scoped_ptr.h"
#include "base/string16.h"
+class ExtensionIconSet;
+
namespace base {
class DictionaryValue;
}
-class ExtensionIconSet;
-
namespace extensions {
-
-struct ActionInfo;
-class Extension;
-
namespace manifest_handler_helpers {
// Strips leading slashes from the file path. Returns true iff the final path is
@@ -37,14 +33,6 @@ bool LoadIconsFromDictionary(const base::DictionaryValue* icons_value,
ExtensionIconSet* icons,
string16* error);
-// TODO(rdevlin.cronin): Move this to a helper file in
-// chrome/common/extensions/api/extension_action/ when the Extension class stops
-// using it.
-scoped_ptr<ActionInfo> LoadActionInfo(
- const Extension* extension,
- const base::DictionaryValue* manifest_section,
- string16* error);
-
} // namespace manifest_handler_helpers
} // namespace extensions
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/manifest_handler_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698