Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/common/extensions/manifest_handler_helpers.h

Issue 12618009: Move SystemIndicator parsing out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_HELPERS_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_HELPERS_H_
6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_HELPERS_H_ 6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_HELPERS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/string16.h" 11 #include "base/string16.h"
12 12
13 class ExtensionIconSet;
14
13 namespace base { 15 namespace base {
14 class DictionaryValue; 16 class DictionaryValue;
15 } 17 }
16 18
17 class ExtensionIconSet;
18
19 namespace extensions { 19 namespace extensions {
20
21 struct ActionInfo;
22 class Extension;
23
24 namespace manifest_handler_helpers { 20 namespace manifest_handler_helpers {
25 21
26 // Strips leading slashes from the file path. Returns true iff the final path is 22 // Strips leading slashes from the file path. Returns true iff the final path is
27 // non empty. 23 // non empty.
28 bool NormalizeAndValidatePath(std::string* path); 24 bool NormalizeAndValidatePath(std::string* path);
29 25
30 // Loads icon paths defined in dictionary |icons_value| into ExtensionIconSet 26 // Loads icon paths defined in dictionary |icons_value| into ExtensionIconSet
31 // |icons|. |icons_value| is a dictionary value {icon size -> icon path}. Icons 27 // |icons|. |icons_value| is a dictionary value {icon size -> icon path}. Icons
32 // in |icons_value| whose size is not in |icon_sizes| will be ignored. 28 // in |icons_value| whose size is not in |icon_sizes| will be ignored.
33 // Returns success. If load fails, |error| will be set. 29 // Returns success. If load fails, |error| will be set.
34 bool LoadIconsFromDictionary(const base::DictionaryValue* icons_value, 30 bool LoadIconsFromDictionary(const base::DictionaryValue* icons_value,
35 const int* icon_sizes, 31 const int* icon_sizes,
36 size_t num_icon_sizes, 32 size_t num_icon_sizes,
37 ExtensionIconSet* icons, 33 ExtensionIconSet* icons,
38 string16* error); 34 string16* error);
39 35
40 // TODO(rdevlin.cronin): Move this to a helper file in
41 // chrome/common/extensions/api/extension_action/ when the Extension class stops
42 // using it.
43 scoped_ptr<ActionInfo> LoadActionInfo(
44 const Extension* extension,
45 const base::DictionaryValue* manifest_section,
46 string16* error);
47
48 } // namespace manifest_handler_helpers 36 } // namespace manifest_handler_helpers
49 } // namespace extensions 37 } // namespace extensions
50 38
51 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_HELPERS_H_ 39 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_HELPERS_H_
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/manifest_handler_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698