Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 12542009: Revert "Revert 186416" (Closed)

Created:
7 years, 9 months ago by greggman
Modified:
7 years, 9 months ago
Reviewers:
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Revert "Revert 186416" This reverts commit a8fb8f44bc56943c45bd06034fc004e22ef5da85 and fixes the bug related to the WebGL null object test. BUG=178093 TBR=apatrick@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186573

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+844 lines, -248 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +18 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 9 chunks +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.h View 11 chunks +50 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 4 chunks +77 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 11 chunks +193 lines, -102 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 5 chunks +16 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 8 chunks +59 lines, -76 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 12 chunks +13 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.h View 4 chunks +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 3 chunks +114 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager_unittest.cc View 6 chunks +17 lines, -6 lines 0 comments Download
A gpu/command_buffer/tests/gl_stream_draw_unittests.cc View 1 chunk +157 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12542009/1
7 years, 9 months ago (2013-03-06 20:21:02 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) gpu_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=90364
7 years, 9 months ago (2013-03-06 21:24:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12542009/5002
7 years, 9 months ago (2013-03-06 22:40:35 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-07 01:26:13 UTC) #4
Message was sent while issue was closed.
Change committed as 186573

Powered by Google App Engine
This is Rietveld 408576698