cc: Remove SchedulerStateMachine::UpdateState

cc: Remove SchedulerStateMachine::UpdateState

Also rename UpdateStateOn<Action> to Will<Action> and
call Will<Action> directly from the Scheduler.

This is in preparation of adding a Did<Action> methods
that will allow us to update state immediately
in response to the results of an action.

Update and restructure tests for new interface.

BUG=486072
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/1f154eacd3030a3b9c369675740cac42a0203825
Cr-Commit-Position: refs/heads/master@{#343294}

[brianderson, 2015-07-31 22:39:16]

brianderson@chromium.org changed reviewers:
+ mithro@mithis.com, sunnyps@chromium.org

[brianderson, 2015-07-31 22:39:17]

ptal

[sunnyps, 2015-08-01 00:59:14]

LGTM

https://codereview.chromium.org/1253203003/diff/20001/cc/scheduler/scheduler_...
File cc/scheduler/scheduler_state_machine.h (right):

https://codereview.chromium.org/1253203003/diff/20001/cc/scheduler/scheduler_...
cc/scheduler/scheduler_state_machine.h:125: void WillAction(Action action);
nit: WillPerformAction?

[mithro-old, 2015-08-01 01:02:21]

On 2015/08/01 00:59:14, sunnyps wrote:
> LGTM
> 
>
https://codereview.chromium.org/1253203003/diff/20001/cc/scheduler/scheduler_...
> File cc/scheduler/scheduler_state_machine.h (right):
> 
>
https://codereview.chromium.org/1253203003/diff/20001/cc/scheduler/scheduler_...
> cc/scheduler/scheduler_state_machine.h:125: void WillAction(Action action);
> nit: WillPerformAction?

I like WillPerformAction more then WillAction.

[sunnyps, 2015-08-01 01:08:28]

Also, have you considered the following instead:

switch(NextAction()) {

case DRAW:
  state_machine_.WillDraw();
  client_->Draw();
  state_machine_.DidDraw(result);

}

It seems weird that we have a switch statement for choosing actions so many
times - once in the scheduler and then twice in the state machine (after
DidAction is added) instead of only once - in the scheduler.

[brianderson, 2015-08-01 02:07:19]

On 2015/08/01 01:08:28, sunnyps wrote:
> Also, have you considered the following instead:
> 
> switch(NextAction()) {
> 
> case DRAW:
>   state_machine_.WillDraw();
>   client_->Draw();
>   state_machine_.DidDraw(result);
> 
> }
> 
> It seems weird that we have a switch statement for choosing actions so many
> times - once in the scheduler and then twice in the state machine (after
> DidAction is added) instead of only once - in the scheduler.

Done. Forced me to clean up some tests in the process!

Ptal.

[brianderson, 2015-08-03 22:55:52]

+Dana and Vlad to keep them in the loop regarding checkerboard-related work.

[brianderson, 2015-08-03 22:56:11]

The CQ bit was checked by brianderson@chromium.org

[brianderson, 2015-08-03 22:56:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sunnyps@chromium.org
Link to the patchset: https://codereview.chromium.org/1253203003/#ps40001
(title: "nix WillAction")

[commit-bot: I haz the power, 2015-08-03 22:56:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253203003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253203003/40001

[commit-bot: I haz the power, 2015-08-04 00:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 00:10:13]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brianderson, 2015-08-13 21:53:26]

The CQ bit was checked by brianderson@chromium.org

[commit-bot: I haz the power, 2015-08-13 21:53:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253203003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253203003/40001

[commit-bot: I haz the power, 2015-08-13 22:55:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-13 22:56:35]

Patchset 3 (id:??) landed as
https://crrev.com/1f154eacd3030a3b9c369675740cac42a0203825
Cr-Commit-Position: refs/heads/master@{#343294}