Issue 12395028: [android] Always close Autofill popup through controller.

Issue 12395028: [android] Always close Autofill popup through controller. (Closed)

Created:
7 years, 9 months ago by aurimas (slooooooooow)

Modified:
7 years, 9 months ago

Reviewers:
Ilya Sherman, Yaron, csharp

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android] Always close Autofill popup through controller. Make sure that if dismiss is called by phone rotation it requests the controller to dismiss the view instead of dismissing itself. Dependent on https://chromiumcodereview.appspot.com/12556002 BUG=175454 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187018

Patch Set 1 #

Patch Set 2 : Updated a comment #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase 2 #

Patch Set 5 : Rebase 3 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -19 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java	View		2 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java	View	1	5 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/test/AutofillTest.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/android/autofill/autofill_popup_view_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/android/autofill/autofill_popup_view_android.cc	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

aurimas (slooooooooow)

Hey Yaron, Could you take a look at this CL? Thanks, Aurimas

7 years, 9 months ago (2013-03-04 23:16:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/12395028/12001

7 years, 9 months ago (2013-03-08 19:28:25 UTC) #6

Message was sent while issue was closed.

Change committed as 187018

Expand Messages | Collapse Messages