Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2599)

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 12395028: [android] Always close Autofill popup through controller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase 3 Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/android/autofill/autofill_popup_view_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
index 4faf5639c763e7e98787d0c8a39feb56c9f8db95..b72b3db1a194d74de1fd9396440036e63e2e2c56 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
@@ -38,7 +38,8 @@ void AutofillPopupViewAndroid::Hide() {
AutofillPopupView::Hide();
JNIEnv* env = base::android::AttachCurrentThread();
- Java_AutofillPopupGlue_dismiss(env, java_object_.obj());
+ Java_AutofillPopupGlue_hide(env, java_object_.obj());
+ delete this;
}
void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
@@ -84,8 +85,8 @@ void AutofillPopupViewAndroid::SuggestionSelected(JNIEnv* env,
controller_->AcceptSuggestion(list_index);
}
-void AutofillPopupViewAndroid::Dismissed(JNIEnv* env, jobject obj) {
- delete this;
+void AutofillPopupViewAndroid::RequestHide(JNIEnv* env, jobject obj) {
+ controller_->Hide();
}
void AutofillPopupViewAndroid::InvalidateRow(size_t) {}
« no previous file with comments | « chrome/browser/ui/android/autofill/autofill_popup_view_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698