Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 12388018: Re-enable support for --disallow-unsafe-eval. (Closed)

Created:
7 years, 9 months ago by kasperl
Modified:
7 years, 9 months ago
Reviewers:
erikcorry, ahe, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-enable support for --disallow-unsafe-eval. R=erikcorry@google.com,ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19219

Patch Set 1 #

Patch Set 2 : Fix long lines. #

Total comments: 6

Patch Set 3 : Update status files. #

Patch Set 4 : Address review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -120 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 3 chunks +1 line, -14 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 5 chunks +11 lines, -14 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart View 1 2 3 3 chunks +83 lines, -88 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/html/html.status View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kasperl
7 years, 9 months ago (2013-02-28 12:54:04 UTC) #1
kasperl
Notice that this can now be tested using: $ test.py --csp ... and if you're ...
7 years, 9 months ago (2013-02-28 12:59:14 UTC) #2
erikcorry
LGTM
7 years, 9 months ago (2013-02-28 13:06:08 UTC) #3
ngeoffray
https://codereview.chromium.org/12388018/diff/3001/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart (right): https://codereview.chromium.org/12388018/diff/3001/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart#newcode34 sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart:34: // Class fields are dynamically generated so they are ...
7 years, 9 months ago (2013-02-28 13:11:31 UTC) #4
kasperl
https://codereview.chromium.org/12388018/diff/3001/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart (right): https://codereview.chromium.org/12388018/diff/3001/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart#newcode34 sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart:34: // Class fields are dynamically generated so they are ...
7 years, 9 months ago (2013-02-28 13:18:48 UTC) #5
kasperl
7 years, 9 months ago (2013-02-28 13:21:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r19219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698