sdk/lib/_internal/compiler/implementation/js_backend/backend.dart - Issue 12388018: Re-enable support for --disallow-unsafe-eval.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 12388018: Re-enable support for --disallow-unsafe-eval. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review feedback. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

index 0cf37acd49dae05c9dbbc1673c5d2e08187ba8bb..585c53c354c0ba3e45ea4c1a377418f182a1afcb 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

@@ -738,8 +738,7 @@ class JavaScriptBackend extends Backend {

interceptedClasses = new LinkedHashMap<ClassElement, ClassElement>(),

super(compiler, JAVA_SCRIPT_CONSTANT_SYSTEM) {

emitter = disableEval

- // TODO(8522): Restore --disallow-unsafe-eval.

- ? null // new CodeEmitterNoEvalTask(compiler, namer, generateSourceMap)

+ ? new CodeEmitterNoEvalTask(compiler, namer, generateSourceMap)

: new CodeEmitterTask(compiler, namer, generateSourceMap);

builder = new SsaBuilderTask(this);

optimizer = new SsaOptimizerTask(this);