Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12387089: Instant: Rename 'preview' to 'overlay' (Closed)

Created:
7 years, 9 months ago by sreeram
Modified:
7 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, melevin, samarth+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, gideonwald, dcheng, sreeram, dominich, sail+watch_chromium.org, David Black, arv+watch_chromium.org, oshima+watch_chromium.org, Jered
Visibility:
Public.

Description

Instant: Rename 'preview' to 'overlay' This CL has only cosmetic changes. It's in service of a larger refactor. Also: + Renames InstantModel* to InstantOverlayModel* to make it clear that the model is meant only for the overlay, and not committed tabs that Instant works with. BUG=none R=sky@chromium.org TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1134 lines, -1787 lines) Patch
chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
chrome/app/theme/default_100_percent/common/overlay_drop_shadow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/app/theme/default_100_percent/common/preview_drop_shadow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_200_percent/common/overlay_drop_shadow.png View Binary file 0 comments Download
chrome/app/theme/default_200_percent/common/preview_drop_shadow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/app/theme/theme_resources.grd View 2 chunks +1 line, -1 line 0 comments Download
chrome/browser/infobars/infobar_container.h View 4 chunks +5 lines, -5 lines 0 comments Download
chrome/browser/infobars/infobar_container.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 36 chunks +161 lines, -161 lines 0 comments Download
chrome/browser/instant/instant_controller.h View 12 chunks +32 lines, -31 lines 0 comments Download
chrome/browser/instant/instant_controller.cc View 35 chunks +81 lines, -81 lines 0 comments Download
chrome/browser/instant/instant_extended_browsertest.cc View 31 chunks +68 lines, -68 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/instant/instant_model.h View 1 chunk +0 lines, -64 lines 0 comments Download
chrome/browser/instant/instant_model.cc View 1 chunk +0 lines, -64 lines 0 comments Download
chrome/browser/instant/instant_model_observer.h View 1 chunk +0 lines, -21 lines 0 comments Download
chrome/browser/instant/instant_ntp.h View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/instant/instant_overlay.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/instant/instant_overlay.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/instant/instant_overlay_controller.h View 1 chunk +28 lines, -0 lines 0 comments Download
chrome/browser/instant/instant_overlay_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
chrome/browser/instant/instant_overlay_model.h View 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/browser/instant/instant_overlay_model.cc View 1 chunk +66 lines, -0 lines 0 comments Download
chrome/browser/instant/instant_overlay_model_observer.h View 1 chunk +21 lines, -0 lines 0 comments Download
chrome/browser/instant/instant_preview_controller.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/instant/instant_preview_controller.cc View 1 chunk +0 lines, -19 lines 0 comments Download
chrome/browser/instant/instant_test_utils.h View 3 chunks +8 lines, -8 lines 0 comments Download
chrome/browser/instant/instant_test_utils.cc View 5 chunks +8 lines, -7 lines 0 comments Download
chrome/browser/resources/instant/instant.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/instant/instant.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/instant/instant.js View 3 chunks +3 lines, -6 lines 0 comments Download
chrome/browser/task_manager/task_manager_resource_providers.h View 4 chunks +4 lines, -5 lines 0 comments Download
chrome/browser/task_manager/task_manager_resource_providers.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -3 lines 0 comments Download
chrome/browser/ui/browser.cc View 3 chunks +5 lines, -6 lines 0 comments Download
chrome/browser/ui/browser_instant_controller.h View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 2 chunks +1 line, -2 lines 0 comments Download
chrome/browser/ui/cocoa/browser_window_controller.h View 5 chunks +6 lines, -6 lines 0 comments Download
chrome/browser/ui/cocoa/browser_window_controller.mm View 8 chunks +12 lines, -14 lines 0 comments Download
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 6 chunks +36 lines, -36 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 2 chunks +2 lines, -3 lines 0 comments Download
chrome/browser/ui/cocoa/browser_window_controller_private.mm View 6 chunks +12 lines, -12 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.h View 1 chunk +33 lines, -0 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.mm View 1 chunk +15 lines, -16 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.h View 1 chunk +0 lines, -33 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.mm View 1 chunk +0 lines, -44 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view.mm View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view_unittest.mm View 1 chunk +8 lines, -8 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h View 3 chunks +28 lines, -28 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm View 6 chunks +47 lines, -48 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm View 2 chunks +44 lines, -43 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/preview_drop_shadow_view.h View 1 chunk +0 lines, -13 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/preview_drop_shadow_view.mm View 1 chunk +0 lines, -32 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/preview_drop_shadow_view_unittest.mm View 1 chunk +0 lines, -27 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h View 1 chunk +0 lines, -92 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.mm View 1 chunk +0 lines, -180 lines 0 comments Download
chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_browsertest.mm View 1 chunk +0 lines, -143 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 3 chunks +4 lines, -4 lines 0 comments Download
chrome/browser/ui/gtk/instant_overlay_controller_gtk.h View 1 chunk +31 lines, -0 lines 0 comments Download
chrome/browser/ui/gtk/instant_overlay_controller_gtk.cc View 1 chunk +9 lines, -9 lines 0 comments Download
chrome/browser/ui/gtk/instant_preview_controller_gtk.h View 1 chunk +0 lines, -31 lines 0 comments Download
chrome/browser/ui/gtk/instant_preview_controller_gtk.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.cc View 4 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 5 chunks +5 lines, -5 lines 0 comments Download
chrome/browser/ui/views/frame/browser_view.cc View 10 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 2 chunks +3 lines, -3 lines 0 comments Download
chrome/browser/ui/views/frame/contents_container.h View 3 chunks +23 lines, -23 lines 0 comments Download
chrome/browser/ui/views/frame/contents_container.cc View 6 chunks +67 lines, -67 lines 0 comments Download
A chrome/browser/ui/views/frame/instant_overlay_controller_views.h View 1 chunk +46 lines, -0 lines 0 comments Download
chrome/browser/ui/views/frame/instant_overlay_controller_views.cc View 2 chunks +26 lines, -26 lines 0 comments Download
chrome/browser/ui/views/frame/instant_preview_controller_views.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/views/frame/instant_preview_controller_views.cc View 1 chunk +0 lines, -63 lines 0 comments Download
chrome/chrome_browser.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
chrome/chrome_browser_ui.gypi View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/chrome_nibs.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -2 lines 0 comments Download
chrome/common/chrome_notification_types.h View 2 chunks +2 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698