Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2389)

Unified Diff: chrome/browser/ui/browser.cc

Issue 12387089: Instant: Rename 'preview' to 'overlay' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_instant_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 99122cc4da51a73ed1ffbe83e0fb397b30bc4736..66551f5803415fc30cc731d3916bd826336fcc64 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1224,11 +1224,11 @@ void Browser::ShowFirstRunBubble() {
window()->GetLocationBar()->ShowFirstRunBubble();
}
-void Browser::MaybeUpdateBookmarkBarStateForInstantPreview(
+void Browser::MaybeUpdateBookmarkBarStateForInstantOverlay(
const chrome::search::Mode& mode) {
// This is invoked by a platform-specific implementation of
- // |InstantPreviewController| to update bookmark bar state according to
- // instant preview state.
+ // |InstantOverlayController| to update bookmark bar state according to
+ // Instant overlay state.
// ModeChanged() updates bookmark bar state for all mode transitions except
// when new mode is |SEARCH_SUGGESTIONS|, because that needs to be done when
// the suggestions are ready.
@@ -1826,8 +1826,8 @@ void Browser::Observe(int type,
void Browser::ModeChanged(const chrome::search::Mode& old_mode,
const chrome::search::Mode& new_mode) {
// If new mode is |SEARCH_SUGGESTIONS|, don't update bookmark bar state now;
- // wait till the instant preview is ready to show suggestions before hiding
- // the bookmark bar (in MaybeUpdateBookmarkBarStateForInstantPreview()).
+ // wait till the Instant overlay is ready to show suggestions before hiding
+ // the bookmark bar (in MaybeUpdateBookmarkBarStateForInstantOverlay()).
// TODO(kuan): but for now, only delay updating bookmark bar state if origin
// is |DEFAULT|; other origins require more complex logic to be implemented
// to prevent jankiness caused by hiding bookmark bar, so just hide the
@@ -1988,7 +1988,6 @@ void Browser::RemoveScheduledUpdatesFor(WebContents* contents) {
scheduled_updates_.erase(i);
}
-
///////////////////////////////////////////////////////////////////////////////
// Browser, Getters for UI (private):
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_instant_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698