Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3893)

Unified Diff: chrome/browser/ui/browser_instant_controller.h

Issue 12387089: Instant: Rename 'preview' to 'overlay' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_instant_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_instant_controller.h
diff --git a/chrome/browser/ui/browser_instant_controller.h b/chrome/browser/ui/browser_instant_controller.h
index aa58261f8a7fcc525ead8a0c96687278dddf1e21..df5303032fabc8bac88bece728aa4d84d5e9fba9 100644
--- a/chrome/browser/ui/browser_instant_controller.h
+++ b/chrome/browser/ui/browser_instant_controller.h
@@ -38,7 +38,7 @@ class BrowserInstantController : public content::NotificationObserver,
explicit BrowserInstantController(Browser* browser);
virtual ~BrowserInstantController();
- // Returns true if Instant is enabled in a visible, preview-showing mode.
+ // Returns true if Instant is enabled in a visible, overlay-showing mode.
static bool IsInstantEnabled(Profile* profile);
// Registers Instant related preferences.
@@ -67,9 +67,9 @@ class BrowserInstantController : public content::NotificationObserver,
// this BrowserInstantController.
InstantController* instant() { return &instant_; }
- // Invoked by |instant_| to commit the |preview| by merging it into the active
+ // Invoked by |instant_| to commit the |overlay| by merging it into the active
// tab or adding it as a new tab.
- void CommitInstant(scoped_ptr<content::WebContents> preview, bool in_new_tab);
+ void CommitInstant(scoped_ptr<content::WebContents> overlay, bool in_new_tab);
// Invoked by |instant_| to autocomplete the |suggestion| into the omnibox.
void SetInstantSuggestion(const InstantSuggestion& suggestion);
@@ -78,19 +78,19 @@ class BrowserInstantController : public content::NotificationObserver,
// Call-through to OmniboxEditModel::CommitSuggestedText.
void CommitSuggestedText(bool skip_inline_autocomplete);
- // Invoked by |instant_| to get the bounds that the preview is placed at,
+ // Invoked by |instant_| to get the bounds that the overlay is placed at,
// in screen coordinates.
gfx::Rect GetInstantBounds();
- // Invoked by |instant_| to notify that the preview gained focus, usually due
+ // Invoked by |instant_| to notify that the overlay gained focus, usually due
// to the user clicking on it.
- void InstantPreviewFocused();
+ void InstantOverlayFocused();
// Invoked by |instant_| to give the omnibox focus invisibly.
void FocusOmniboxInvisibly();
// Invoked by |instant_| to get the currently active tab, over which the
- // preview would be shown.
+ // overlay would be shown.
content::WebContents* GetActiveWebContents() const;
// Invoked by |browser_| when the active tab changes.
@@ -138,7 +138,7 @@ class BrowserInstantController : public content::NotificationObserver,
InstantController instant_;
InstantUnloadHandler instant_unload_handler_;
- // Theme-related data for NTP preview to adopt themes.
+ // Theme-related data for NTP overlay to adopt themes.
bool initialized_theme_info_; // True if theme_info_ has been initialized.
ThemeBackgroundInfo theme_info_;
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_instant_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698