Issue 12386012: sync: Drop fully datatype throttled sync jobs rather than saving them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12386012: sync: Drop fully datatype throttled sync jobs rather than saving them. (Closed)

Created:
7 years, 9 months ago by tim (not reviewing)

Modified:
7 years, 9 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sync: Drop fully datatype throttled sync jobs rather than saving them. This avoids a bug where we loop infinitely with calls to RestartWaiting with a zero WaitInterval length, which happens in part because we don't honour ThrottledDatatypeTracker unthrottle times and rely on seperate exponential backoff treatment. BUG=177659 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185528

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	sync/engine/sync_scheduler_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sync/engine/sync_scheduler_whitebox_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

Wasn't sure if you were writing this, so I just went ahead and did it. ...

7 years, 9 months ago (2013-02-28 03:23:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/12386012/1

7 years, 9 months ago (2013-03-01 08:11:15 UTC) #3

Message was sent while issue was closed.

Change committed as 185528

Expand Messages | Collapse Messages