sync/engine/sync_scheduler_whitebox_unittest.cc - Issue 12386012: sync: Drop fully datatype throttled sync jobs rather than saving them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/sync_scheduler_whitebox_unittest.cc

Issue 12386012: sync: Drop fully datatype throttled sync jobs rather than saving them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/engine/sync_scheduler_whitebox_unittest.cc

diff --git a/sync/engine/sync_scheduler_whitebox_unittest.cc b/sync/engine/sync_scheduler_whitebox_unittest.cc

index 383f17d01fd541ab1002d96b007436282fa9321f..5a9d77408116ddb1d26ccd3e9dee5d3c3e931ec1 100644

--- a/sync/engine/sync_scheduler_whitebox_unittest.cc

+++ b/sync/engine/sync_scheduler_whitebox_unittest.cc

@@ -159,7 +159,8 @@ TEST_F(SyncSchedulerWhiteboxTest, SaveNudgeWhileTypeThrottled) {

ConfigurationParams(),

FROM_HERE);

SyncSchedulerImpl::JobProcessDecision decision = DecideOnJob(job);

- EXPECT_EQ(decision, SyncSchedulerImpl::SAVE);

+ // TODO(tim): This shouldn't drop. Bug 177659.

+ EXPECT_EQ(decision, SyncSchedulerImpl::DROP);

}

TEST_F(SyncSchedulerWhiteboxTest, ContinueNudge) {

« no previous file with comments | « sync/engine/sync_scheduler_impl.cc ('k') | no next file » | no next file with comments »