sync/engine/sync_scheduler_impl.cc - Issue 12386012: sync: Drop fully datatype throttled sync jobs rather than saving them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/sync_scheduler_impl.cc

Issue 12386012: sync: Drop fully datatype throttled sync jobs rather than saving them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/engine/sync_scheduler_impl.cc

diff --git a/sync/engine/sync_scheduler_impl.cc b/sync/engine/sync_scheduler_impl.cc

index ef6ae6d58de7a92d159f569285a6122d499c8043..d0f0c0ed7c7fec0ac38e862f71a94fbda4168cf6 100644

--- a/sync/engine/sync_scheduler_impl.cc

+++ b/sync/engine/sync_scheduler_impl.cc

@@ -429,7 +429,7 @@ SyncSchedulerImpl::JobProcessDecision SyncSchedulerImpl::DecideOnJob(

// Note that there may already be such an event if we're in a WaitInterval,

// so we can retry it then.

if (!requested_types.Empty() && throttled_types.HasAll(requested_types))

- return SAVE;

+ return DROP; // TODO(tim): Don't drop. http://crbug.com/177659

}

if (wait_interval_.get())

« no previous file with comments | « no previous file | sync/engine/sync_scheduler_whitebox_unittest.cc » ('j') | no next file with comments »