Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 12383062: Fixed incorrect page value index lookup when using gtest_repeat with the times/t metric (ie. --gtes… (Closed)

Created:
7 years, 9 months ago by shatch
Modified:
7 years, 9 months ago
Reviewers:
tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed incorrect page value index lookup when using gtest_repeat with the times/t metric (ie. --gtest_repeat=N for N > 1). Refactored code to simplify and added comments as well. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M tools/bisect-perf-regression.py View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
shatch
7 years, 9 months ago (2013-03-01 21:20:20 UTC) #1
tonyg
lgtm
7 years, 9 months ago (2013-03-01 21:34:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/12383062/1
7 years, 9 months ago (2013-03-01 21:46:01 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-01 21:53:45 UTC) #4
Message was sent while issue was closed.
Change committed as 185598

Powered by Google App Engine
This is Rietveld 408576698