Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: tools/bisect-perf-regression.py

Issue 12383062: Fixed incorrect page value index lookup when using gtest_repeat with the times/t metric (ie. --gtes… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index 59d75cbe5b63ad19dc873909b776af6e51dd6a04..d7bf4b2bf8153229447ffffd11b0ffca5113d623 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -502,12 +502,17 @@ class BisectPerformanceMetrics(object):
if not (len(values_list) % len(page_names)):
values_dict = dict([(k, []) for k in page_names])
- num = len(values_list) / len(page_names)
+ # In the case of times/t, values_list is an array of times in the
+ # order of page_names, repeated X number of times.
+ # ie.
+ # page_names = ['www.chromium.org', 'dev.chromium.org']
+ # values_list = [1, 2, 1, 2, 1, 2]
+ num_pages = len(page_names)
- for j in xrange(num):
- for i in xrange(len(page_names)):
- k = num * j + i
- values_dict[page_names[i]].append(values_list[k])
+ for i in xrange(len(values_list)):
+ page_index = i % num_pages
+
+ values_dict[page_names[page_index]].append(values_list[i])
return values_dict
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698