Fixed incorrect page value index lookup when using gtest_repeat with the times/t metric (ie. --gtes…

tools/bisect-perf-regression.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Performance Test Bisect Tool
 
 This script bisects a series of changelists using binary search. It starts at
 a bad revision where a performance metric has regressed, and asks for a last
 known-good revision. It will then binary search across this revision range by
@@ skipping 484 matching lines @@
     if regex_results:
       page_names = regex_results.group('values')
       page_names = page_names.split(',')
 
     if not metric == ['times', 't'] or not page_names:
       values_dict['%s: %s' % (metric[0], metric[1])] = values_list
     else:
       if not (len(values_list) % len(page_names)):
         values_dict = dict([(k, []) for k in page_names])
 
-        num = len(values_list) / len(page_names)
+        # In the case of times/t, values_list is an array of times in the
+        # order of page_names, repeated X number of times.
+        # ie.
+        # page_names = ['www.chromium.org', 'dev.chromium.org']
+        # values_list = [1, 2, 1, 2, 1, 2]
+        num_pages = len(page_names)
 
-        for j in xrange(num):
-          for i in xrange(len(page_names)):
-            k = num * j + i
-            values_dict[page_names[i]].append(values_list[k])
+        for i in xrange(len(values_list)):
+          page_index = i % num_pages
+
+          values_dict[page_names[page_index]].append(values_list[i])
 
     return values_dict
 
   def RunPerformanceTestAndParseResults(self, command_to_run, metric):
     """Runs a performance test on the current revision by executing the
     'command_to_run' and parses the results.
 
     Args:
       command_to_run: The command to be run to execute the performance test.
       metric: The metric to parse out from the results of the performance test.
@@ skipping 712 matching lines @@
   if not(bisect_results['error']):
     bisect_test.FormatAndPrintResults(bisect_results)
     return 0
   else:
     print 'Error: ' + bisect_results['error']
     print
     return 1
 
 if __name__ == '__main__':
   sys.exit(main())