Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 12328079: Update TestURLRequest constructor interface in extensions unit tests. (Closed)

Created:
7 years, 10 months ago by tedv
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Update TestURLRequest constructor interface in extensions unit tests. The TestURLRequest constructor interface is being expanded to allow separate initialization arguments for the URLRequestContext and NetworkDelegate. Most of the time this means making it explicit that the test in question uses no network delegate. This is motivated by a desire to remove external accesses to a request context's delegate. (If a block of code needs to use a NetworkDelegate, it should not query the URLRequestContext for it, but instead should already have access to whatever delegate the context uses.) BUG=146587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187192

Patch Set 1 #

Patch Set 2 : Rebase onto master. #

Messages

Total messages: 4 (0 generated)
tedv
This issue depends on https://codereview.chromium.org/12328072/ which adds the new constructor interface for TestURLRequest.
7 years, 10 months ago (2013-02-25 03:15:01 UTC) #1
Matt Perry
lgtm
7 years, 10 months ago (2013-02-25 22:04:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedv@chromium.org/12328079/4001
7 years, 9 months ago (2013-03-10 02:33:40 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-10 04:34:39 UTC) #4
Message was sent while issue was closed.
Change committed as 187192

Powered by Google App Engine
This is Rietveld 408576698