Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

Issue 12328079: Update TestURLRequest constructor interface in extensions unit tests. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Rebase onto master. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
index a25c1f6b3ab4b2ae84afa0d0e03849bb51e13fd9..77a0a469d63c092eadf2bf4db5965e1af82acb21 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
@@ -137,7 +137,8 @@ TEST(WebRequestActionTest, TestPermissions) {
EXPECT_FALSE(bad_message);
// Check that redirect works on regular URLs but not on protected URLs.
- net::TestURLRequest regular_request(GURL("http://test.com"), NULL, &context);
+ net::TestURLRequest regular_request(
+ GURL("http://test.com"), NULL, &context, NULL);
std::list<LinkedPtrEventResponseDelta> deltas;
WebRequestData request_data(&regular_request, ON_BEFORE_REQUEST);
WebRequestAction::ApplyInfo apply_info = {
@@ -147,7 +148,7 @@ TEST(WebRequestActionTest, TestPermissions) {
EXPECT_EQ(1u, deltas.size());
net::TestURLRequest protected_request(GURL("http://clients1.google.com"),
- NULL, &context);
+ NULL, &context, NULL);
deltas.clear();
request_data = WebRequestData(&protected_request, ON_BEFORE_REQUEST);
// Note that we just updated the request_data reference in apply_info.
« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698