Issue 12321139: Revert 184588 because it leaves the Exit menu disabled on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12321139: Revert 184588 because it leaves the Exit menu disabled on all platforms. (Closed)

Created:
7 years, 10 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 10 months ago

Reviewers:
robertshield

CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 184588 because it leaves the Exit menu disabled on all platforms. > Remove the Exit menu item from the Wrench menu in Win/Ash. > > BUG=176130 > TEST=Metro/Ash chrome browsers lose their Exit menu item. > > > Review URL: https://chromiumcodereview.appspot.com/12330056 TBR=robertshield@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184662

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -14 lines)			Patch
M	ash/accelerators/accelerator_controller_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_command_controller.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Andrew T Wilson (Slow)

7 years, 10 months ago (2013-02-26 16:31:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r184662.