Issue 12330056: Remove the Exit menu item from the Wrench menu in Win/Ash.

Issue 12330056: Remove the Exit menu item from the Wrench menu in Win/Ash. (Closed)

Created:
7 years, 10 months ago by robertshield

Modified:
7 years, 9 months ago

Reviewers:
cpu_(ooo_6.6-7.5), Andrew T Wilson (Slow), Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the Exit menu item from the Wrench menu in Win/Ash. Relanding after a revert in crrev.com/184662 due to accidentally disabling the Exit menu on non Win-Ash platforms. BUG=176130 TEST=Metro/Ash chrome browsers lose their Exit menu item. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184588

Patch Set 1 : #

Patch Set 2 : Disable quit accelerator on win/ash #

Patch Set 3 : Update accelerator unit test. #

Total comments: 1

Patch Set 4 : Don't remove Exit menu item from non win-ash platforms. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
M	ash/accelerators/accelerator_controller_unittest.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_command_controller.cc	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

Is there also an accelerator? if not then lgtm

7 years, 10 months ago (2013-02-21 22:39:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12330056/11002

7 years, 10 months ago (2013-02-22 21:18:23 UTC) #6

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=13372

7 years, 10 months ago (2013-02-23 00:56:56 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12330056/12005

7 years, 10 months ago (2013-02-26 03:10:25 UTC) #8

Andrew T Wilson (Slow)

7 years, 10 months ago (2013-02-26 16:29:36 UTC) #10

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/12330056/diff/12005/chrome/browser/ui/...
File chrome/browser/ui/browser_command_controller.cc (right):

https://chromiumcodereview.appspot.com/12330056/diff/12005/chrome/browser/ui/...
chrome/browser/ui/browser_command_controller.cc:814:
command_updater_.UpdateCommandEnabled(IDC_EXIT, true);
Note that this code is no longer executed on non-win-ash platforms which leaves
Exit disabled permanently.

Expand Messages | Collapse Messages