chrome/installer/util/chrome_binaries_operations.cc - Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/chrome_binaries_operations.cc

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Style changes; removing passing of BrowserDistribution for experiments; specializing LaunchBrowserU… Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/first_run/try_chrome_dialog_view.cc ('K') | « chrome/installer/util/chrome_binaries_operations.h ('k') | chrome/installer/util/chrome_browser_operations.h » ('j') | chrome/installer/util/chrome_browser_operations.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/chrome_binaries_operations.cc

diff --git a/chrome/installer/util/chrome_binaries_operations.cc b/chrome/installer/util/chrome_binaries_operations.cc

index 9a00805847d8c9f08878a9e1febeca6a44a95ca6..055334cbe79ba3e8df6b4f59925e3c69f62eb68d 100644

--- a/chrome/installer/util/chrome_binaries_operations.cc

+++ b/chrome/installer/util/chrome_binaries_operations.cc

@@ -84,4 +84,13 @@ void ChromeBinariesOperations::AddDefaultShortcutProperties(

NOTREACHED() << "Chrome Binaries do not create shortcuts.";

}

+void ChromeBinariesOperations::LaunchUserExperiment(

+ const base::FilePath& setup_path,

+ const std::set<std::wstring>& options,

+ InstallStatus status,

+ bool system_level) const {

+ // Not meaningful to have binaries run experiments.

+ NOTREACHED();

} // namespace installer