Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: chrome/installer/util/chrome_binaries_operations.cc

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Style changes; removing passing of BrowserDistribution for experiments; specializing LaunchBrowserU… Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/chrome_binaries_operations.h" 5 #include "chrome/installer/util/chrome_binaries_operations.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "chrome/installer/util/channel_info.h" 10 #include "chrome/installer/util/channel_info.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 return false; 77 return false;
78 } 78 }
79 79
80 void ChromeBinariesOperations::AddDefaultShortcutProperties( 80 void ChromeBinariesOperations::AddDefaultShortcutProperties(
81 BrowserDistribution* dist, 81 BrowserDistribution* dist,
82 const base::FilePath& target_exe, 82 const base::FilePath& target_exe,
83 ShellUtil::ShortcutProperties* properties) const { 83 ShellUtil::ShortcutProperties* properties) const {
84 NOTREACHED() << "Chrome Binaries do not create shortcuts."; 84 NOTREACHED() << "Chrome Binaries do not create shortcuts.";
85 } 85 }
86 86
87 void ChromeBinariesOperations::LaunchUserExperiment(
88 const base::FilePath& setup_path,
89 const std::set<std::wstring>& options,
90 InstallStatus status,
91 bool system_level) const {
92 // Not meaningful to have binaries run experiments.
93 NOTREACHED();
94 }
95
87 } // namespace installer 96 } // namespace installer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698