Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3196)

Unified Diff: chrome/installer/util/chrome_browser_operations.cc

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Style changes; removing passing of BrowserDistribution for experiments; specializing LaunchBrowserU… Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/chrome_browser_operations.cc
diff --git a/chrome/installer/util/chrome_browser_operations.cc b/chrome/installer/util/chrome_browser_operations.cc
index 1f232616217710ca532553f70cad7f32384b8c13..c69337b28ff885de924a0aaf533fbc0dbece0ea8 100644
--- a/chrome/installer/util/chrome_browser_operations.cc
+++ b/chrome/installer/util/chrome_browser_operations.cc
@@ -16,6 +16,7 @@
#include "chrome/installer/util/master_preferences.h"
#include "chrome/installer/util/master_preferences_constants.h"
#include "chrome/installer/util/shell_util.h"
+#include "chrome/installer/util/user_experiment.h"
#include "chrome/installer/util/util_constants.h"
namespace installer {
@@ -136,4 +137,20 @@ void ChromeBrowserOperations::AddDefaultShortcutProperties(
properties->set_description(dist->GetAppDescription());
}
+void ChromeBrowserOperations::LaunchUserExperiment(
+ const base::FilePath& setup_path,
+ const std::set<std::wstring>& options,
+ InstallStatus status,
+ bool system_level) const {
+ BrowserDistribution* dist = BrowserDistribution::GetSpecificDistribution(
grt (UTC plus 2) 2013/03/12 19:36:18 please move into the if(){} block in product.cc as
huangs 2013/03/14 17:20:45 Done. Sorry, misread!
+ BrowserDistribution::CHROME_BROWSER);
+ VLOG(1) << "LaunchUserExperiment status: " << status << " product: "
+ << dist->GetAppShortCutName()
+ << " system_level: " << system_level;
+
+ CommandLine base_command(setup_path);
+ AppendProductFlags(options, &base_command);
+ installer::LaunchBrowserUserExperiment(base_command, status, system_level);
+}
+
} // namespace installer

Powered by Google App Engine
This is Rietveld 408576698