Extract debugger target enumeration into a separate class

content/browser/devtools/devtools_agent_host_impl.cc

Index: content/browser/devtools/devtools_agent_host_impl.cc
diff --git a/content/browser/devtools/devtools_agent_host_impl.cc b/content/browser/devtools/devtools_agent_host_impl.cc
index 0474103a4232e1c39c790fda2d4acd26b2442466..5702197f6a8b94c29e02bb1451c65e26a0f280c6 100644
--- a/content/browser/devtools/devtools_agent_host_impl.cc
+++ b/content/browser/devtools/devtools_agent_host_impl.cc
@@ -6,6 +6,7 @@
 
 #include "base/basictypes.h"
 #include "content/common/devtools_messages.h"
+#include "content/public/browser/devtools_manager.h"
 
 namespace content {
 
@@ -58,6 +59,26 @@ RenderViewHost* DevToolsAgentHostImpl::GetRenderViewHost() {
   return NULL;
 }
 
+bool DevToolsAgentHostImpl::attached() {
+  return !!DevToolsManager::GetInstance()->GetDevToolsClientHostFor(this);

[pfeldman, 2013/03/01 14:28:17]

So this is a convenience method that only depends on public API - let call sites
do that on their own. There is nothing virtual about it.

[Vladislav Kaznacheev, 2013/03/01 16:16:38]

Done.

+}
+
+std::string DevToolsAgentHostImpl::title() {
+  return "";
+}
+
+GURL DevToolsAgentHostImpl::url() {
+  return GURL();
+}
+
+GURL DevToolsAgentHostImpl::thumbnail_url() {
+  return GURL();
+}
+
+GURL DevToolsAgentHostImpl::favicon_url() {
+  return GURL();
+}
+
 void DevToolsAgentHostImpl::NotifyCloseListener() {
   if (close_listener_) {
     scoped_refptr<DevToolsAgentHostImpl> protect(this);