Extract debugger target enumeration into a separate class

content/browser/devtools/devtools_agent_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_agent_host_impl.h"
 
 #include "base/basictypes.h"
 #include "content/common/devtools_messages.h"
+#include "content/public/browser/devtools_manager.h"
 
 namespace content {
 
 namespace {
 static int g_next_agent_host_id = 0;
 }  // namespace
 
 DevToolsAgentHostImpl::DevToolsAgentHostImpl()
     : close_listener_(NULL),
       id_(++g_next_agent_host_id) {
@@ skipping 32 matching lines @@
   SendMessageToAgent(new DevToolsAgentMsg_AddMessageToConsole(
       MSG_ROUTING_NONE,
       level,
       message));
 }
 
 RenderViewHost* DevToolsAgentHostImpl::GetRenderViewHost() {
   return NULL;
 }
 
+bool DevToolsAgentHostImpl::attached() {
+  return !!DevToolsManager::GetInstance()->GetDevToolsClientHostFor(this);

[pfeldman, 2013/03/01 14:28:17]

So this is a convenience method that only depends on public API - let call sites
do that on their own. There is nothing virtual about it.

[Vladislav Kaznacheev, 2013/03/01 16:16:38]

Done.

+}
+
+std::string DevToolsAgentHostImpl::title() {
+  return "";
+}
+
+GURL DevToolsAgentHostImpl::url() {
+  return GURL();
+}
+
+GURL DevToolsAgentHostImpl::thumbnail_url() {
+  return GURL();
+}
+
+GURL DevToolsAgentHostImpl::favicon_url() {
+  return GURL();
+}
+
 void DevToolsAgentHostImpl::NotifyCloseListener() {
   if (close_listener_) {
     scoped_refptr<DevToolsAgentHostImpl> protect(this);
     close_listener_->AgentHostClosing(this);
     close_listener_ = NULL;
   }
 }
 
 }  // namespace content