Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Addressed comments, split the patch in two Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.h
diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h
index c3a52155f91294dd70f9fa3cab7d31f258eeff58..587c4f3e74dbdd9c29430cf8200c70a81e6d27c5 100644
--- a/content/browser/devtools/devtools_agent_host_impl.h
+++ b/content/browser/devtools/devtools_agent_host_impl.h
@@ -41,11 +41,21 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
close_listener_ = listener;
}
- int id() { return id_; }
-
// DevToolsAgentHost implementation.
+ virtual int id() OVERRIDE { return id_; }
+
virtual RenderViewHost* GetRenderViewHost() OVERRIDE;
+ virtual bool attached() OVERRIDE;
+
+ virtual std::string title() OVERRIDE;
+
+ virtual GURL url() OVERRIDE;
+
+ virtual GURL thumbnail_url() OVERRIDE;
+
+ virtual GURL favicon_url() OVERRIDE;
+
protected:
DevToolsAgentHostImpl();
virtual ~DevToolsAgentHostImpl() {}

Powered by Google App Engine
This is Rietveld 408576698