Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 12286014: Factor out uses of WebContentsModalDialog interface functions from WebContentsModalDialogManager (Closed)

Created:
7 years, 10 months ago by Mike Wittman
Modified:
7 years, 10 months ago
CC:
chromium-reviews, tfarina, sail+watch_chromium.org, dvh
Visibility:
Public.

Description

Factor out uses of WebContentsModalDialog interface functions from WebContentsModalDialogManager This CL is part 3 of 6 in the work to remove the WebContentsModalDialog interface. It removes uses of the WebContentsModalDialog interface from WebContentsModalDialogManager, in favor of delegating to the appropriate NativeWebContentsModalDialogManager subclass. This adds new subclasses for Cocoa and Gtk to handle those platforms. This builds on part 2 in https://codereview.chromium.org/12276010. BUG=157161 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184259

Patch Set 1 #

Patch Set 2 : fix unit test failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -24 lines) Patch
chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm View 1 chunk +46 lines, -1 line 0 comments Download
chrome/browser/ui/gtk/constrained_window_gtk.cc View 1 chunk +5 lines, -0 lines 0 comments Download
chrome/browser/ui/gtk/web_contents_modal_dialog_manager_gtk.cc View 1 chunk +48 lines, -1 line 0 comments Download
chrome/browser/ui/native_web_contents_modal_dialog_manager.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc View 3 chunks +17 lines, -0 lines 0 comments Download
chrome/browser/ui/web_contents_modal_dialog_manager.cc View 5 chunks +9 lines, -9 lines 0 comments Download
chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc View 1 3 chunks +37 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike Wittman
Ben, please take a look at the non-Cocoa parts of this. Sailesh, please take a ...
7 years, 10 months ago (2013-02-16 00:51:18 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 10 months ago (2013-02-16 00:58:27 UTC) #2
Elliot Glaysher
gtk lgtm
7 years, 10 months ago (2013-02-16 01:02:15 UTC) #3
sail
I'm not sure what NativeWebContentsModalDialogManager is but LGTM I guess.
7 years, 10 months ago (2013-02-16 21:52:00 UTC) #4
Mike Wittman
On 2013/02/16 21:52:00, sail wrote: > I'm not sure what NativeWebContentsModalDialogManager is but LGTM I ...
7 years, 10 months ago (2013-02-22 21:02:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/12286014/8003
7 years, 10 months ago (2013-02-22 22:14:49 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-23 02:23:05 UTC) #7
Message was sent while issue was closed.
Change committed as 184259

Powered by Google App Engine
This is Rietveld 408576698