Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: chrome/browser/ui/gtk/constrained_window_gtk.cc

Issue 12286014: Factor out uses of WebContentsModalDialog interface functions from WebContentsModalDialogManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unit test failure Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/constrained_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/constrained_window_gtk.cc b/chrome/browser/ui/gtk/constrained_window_gtk.cc
index 1b1b47498665a5eb7609bd8647ac7accf16f5942..e35764e7928ebec9bfc3b7e2e5e4316d20b59763 100644
--- a/chrome/browser/ui/gtk/constrained_window_gtk.cc
+++ b/chrome/browser/ui/gtk/constrained_window_gtk.cc
@@ -73,6 +73,11 @@ ConstrainedWindowGtk::ConstrainedWindowGtk(
g_signal_connect(widget(), "hierarchy-changed",
G_CALLBACK(OnHierarchyChangedThunk), this);
+ // TODO(wittman): Getting/setting data on the widget is a hack to facilitate
+ // looking up the ConstrainedWindowGtk from the GtkWindow during refactoring.
+ // Remove once ConstrainedWindowGtk is gone.
+ g_object_set_data(G_OBJECT(widget()), "ConstrainedWindowGtk", this);
+
WebContentsModalDialogManager* web_contents_modal_dialog_manager =
WebContentsModalDialogManager::FromWebContents(web_contents_);
web_contents_modal_dialog_manager->AddDialog(this);

Powered by Google App Engine
This is Rietveld 408576698