Revert "Add SetUploadDataStream method to URLFetcher." which broke URLFetcher retries.

Revert "Add SetUploadDataStream method to URLFetcher." which broke URLFetcher retries.

This reverts r178535.

Original Review URL: https://chromiumcodereview.appspot.com/11843003

BUG=169551, 175038
TEST=net_unittests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182558

[mattm, 2013-02-13 23:05:26]

Unfortunately there were some conflicts, which I have done my best to resolve. I
had to add a "bool upload_content_set_" to keep the meaning of the DCHECK that
has been added in StartURLRequest.

[rmsousa, 2013-02-13 23:13:49]

lgtm

[hidehiko, 2013-02-14 04:25:42]

Sorry, but I'm not very sure about the background of the original CL. Ryo, could
you kindly take a look, as you're listed in the reviewer of the original CL?

[hashimoto, 2013-02-14 04:36:59]

On 2013/02/14 04:25:42, hidehiko wrote:
> Sorry, but I'm not very sure about the background of the original CL. Ryo,
could
> you kindly take a look, as you're listed in the reviewer of the original CL?

Original CL was intended to improve safe browsing feedback.
(https://chromiumcodereview.appspot.com/11843003#msg4)
Since the newly added method, SetUploadDataStream, is not used by anyone yet,
and it breaks the retry behavior of URLFetcher, we are going to revert the
change for now.

[mmenke, 2013-02-14 04:46:23]

On 2013/02/14 04:36:59, hashimoto wrote:
> On 2013/02/14 04:25:42, hidehiko wrote:
> > Sorry, but I'm not very sure about the background of the original CL. Ryo,
> could
> > you kindly take a look, as you're listed in the reviewer of the original CL?
> 
> Original CL was intended to improve safe browsing feedback.
> (https://chromiumcodereview.appspot.com/11843003#msg4)
> Since the newly added method, SetUploadDataStream, is not used by anyone yet,
> and it breaks the retry behavior of URLFetcher, we are going to revert the
> change for now.

Hidehiko:  Don't think you need to worry about reviewing this.  You're just an
innocent bystander here.  :)

[mmenke, 2013-02-14 15:24:56]

LGTM

[commit-bot: I haz the power, 2013-02-14 21:04:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/12261025/1

[commit-bot: I haz the power, 2013-02-14 22:30:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/12261025/1

[commit-bot: I haz the power, 2013-02-14 22:36:01]

Change committed as 182558