Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2593)

Unified Diff: net/url_request/url_fetcher_core.h

Issue 12261025: Revert "Add SetUploadDataStream method to URLFetcher." which broke URLFetcher retries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_fetcher.h ('k') | net/url_request/url_fetcher_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_fetcher_core.h
diff --git a/net/url_request/url_fetcher_core.h b/net/url_request/url_fetcher_core.h
index ff8677cfb12ec21c0408a3563896a8472d24bc8d..c3de55b694bacfa84ea6d23c74a1709f4d9141a8 100644
--- a/net/url_request/url_fetcher_core.h
+++ b/net/url_request/url_fetcher_core.h
@@ -61,8 +61,6 @@ class URLFetcherCore
// For POST requests, set |content_type| to the MIME type of the
// content and set |content| to the data to upload.
- void SetUploadDataStream(const std::string& upload_content_type,
- scoped_ptr<UploadDataStream> upload_content);
void SetUploadData(const std::string& upload_content_type,
const std::string& upload_content);
void SetChunkedUpload(const std::string& upload_content_type);
@@ -335,7 +333,8 @@ class URLFetcherCore
bool was_fetched_via_proxy_;
HostPortPair socket_address_;
- scoped_ptr<UploadDataStream> upload_content_; // HTTP POST payload
+ bool upload_content_set_; // SetUploadData has been called
+ std::string upload_content_; // HTTP POST payload
std::string upload_content_type_; // MIME type of POST payload
std::string referrer_; // HTTP Referer header value
bool is_chunked_upload_; // True if using chunked transfer encoding
« no previous file with comments | « net/url_request/url_fetcher.h ('k') | net/url_request/url_fetcher_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698