skia/skia.gyp - Issue 12258039: enable -Wstring-conversion when compiling with clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/skia.gyp

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enable on mac, better fix in web_data_service Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/skia.gyp

diff --git a/skia/skia.gyp b/skia/skia.gyp

index 0bf1e97a8d1102de1591a6490e0c8917e431b7ba..2bb2b4c2a9e7f7b9c59ba97f14073a19a53d5776 100644

--- a/skia/skia.gyp

+++ b/skia/skia.gyp

@@ -539,6 +539,18 @@

}],

+ # TODO(scottmg): http://crbug.com/177306

+ ['clang==1', {

+ 'xcode_settings': {

+ 'WARNING_CFLAGS!': [

+ # Don't warn about string->bool used in asserts.

+ '-Wstring-conversion',

+ ],

+ },

+ 'cflags!': [

+ '-Wstring-conversion',

+ ],

+ }],

'dependencies': [

'skia_opts',

« no previous file with comments | « ppapi/examples/video_decode/video_decode.cc ('k') | sync/syncable/entry_kernel.cc » ('j') | no next file with comments »