Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: ppapi/examples/video_decode/video_decode.cc

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: enable on mac, better fix in web_data_service Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webdata/web_data_service.cc ('k') | skia/skia.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/examples/video_decode/video_decode.cc
diff --git a/ppapi/examples/video_decode/video_decode.cc b/ppapi/examples/video_decode/video_decode.cc
index a0469f3e2d2871837c18bc89c461aebaa7a46609..9758f215650e4929110705b6b3e3c7438e2a9ccb 100644
--- a/ppapi/examples/video_decode/video_decode.cc
+++ b/ppapi/examples/video_decode/video_decode.cc
@@ -70,7 +70,7 @@ class VideoDecodeDemoInstance : public pp::Instance,
// particular need to delete context_ and re-create textures.
// Probably have to recreate the decoder from scratch, because old textures
// can still be outstanding in the decoder!
- assert(!"Unexpectedly lost graphics context");
+ assert(false && "Unexpectedly lost graphics context");
}
// pp::VideoDecoderClient_Dev implementation.
@@ -461,7 +461,7 @@ void VideoDecodeDemoInstance::PictureReady(PP_Resource decoder,
void VideoDecodeDemoInstance::NotifyError(PP_Resource decoder,
PP_VideoDecodeError_Dev error) {
LogError(this).s() << "Received error: " << error;
- assert(!"Unexpected error; see stderr for details");
+ assert(false && "Unexpected error; see stderr for details");
}
// This object is the global object representing this plugin library as long
« no previous file with comments | « chrome/browser/webdata/web_data_service.cc ('k') | skia/skia.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698