sync/syncable/entry_kernel.cc - Issue 12258039: enable -Wstring-conversion when compiling with clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/entry_kernel.cc

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enable on mac, better fix in web_data_service Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/syncable/entry_kernel.cc

diff --git a/sync/syncable/entry_kernel.cc b/sync/syncable/entry_kernel.cc

index b8ac824a81972107cbb706e03a9c038694d0c58a..5b21612139554895fab2df440bbca858549e38e0 100644

--- a/sync/syncable/entry_kernel.cc

+++ b/sync/syncable/entry_kernel.cc

@@ -74,7 +74,7 @@ void SetEncryptableProtoValues(

cryptographer->CanDecrypt(encrypted) &&

cryptographer->Decrypt(encrypted, &decrypted)) {

value = EntitySpecificsToValue(decrypted);

- value->SetBoolean("encrypted", "true");

+ value->SetBoolean("encrypted", true);

} else {

value = EntitySpecificsToValue(kernel.ref(field));

}

« no previous file with comments | « skia/skia.gyp ('k') | third_party/libjingle/libjingle.gyp » ('j') | no next file with comments »