Support panel titles and Icons for v1 apps

Support panel titles and Icons for v1 apps
Also don't minimize when clicking on titlebar


BUG=160645
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183369

[jeremya, 2013-02-15 03:28:16]

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/extensions/...
File chrome/browser/ui/extensions/shell_window.h (right):

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/extensions/...
chrome/browser/ui/extensions/shell_window.h:134: bool window_type_panel() const
{
is_panel()

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/views/exten...
File chrome/browser/ui/views/extensions/native_app_window_views.cc (right):

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/native_app_window_views.cc:149: if
(ash::Shell::HasInstance()) {
not sure I understand this -- won't the 'ash' namespace be undefined if
!defined(USE_ASH)?

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/native_app_window_views.cc:336: return
shell_window_->window_type() == ShellWindow::WINDOW_TYPE_V1_PANEL;
This class is getting pretty tangly :(

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/native_app_window_views.cc:360: return
shell_window_->window_type() == ShellWindow::WINDOW_TYPE_V1_PANEL;
What does this do on Windows (or do we never create V1_PANEL types there?)

[stevenjb, 2013-02-15 18:26:35]

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/extensions/...
File chrome/browser/ui/extensions/shell_window.h (right):

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/extensions/...
chrome/browser/ui/extensions/shell_window.h:134: bool window_type_panel() const
{
On 2013/02/15 03:28:16, jeremya wrote:
> is_panel()
done

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/views/exten...
File chrome/browser/ui/views/extensions/native_app_window_views.cc (right):

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/native_app_window_views.cc:149: if
(ash::Shell::HasInstance()) {
On 2013/02/15 03:28:16, jeremya wrote:
> not sure I understand this -- won't the 'ash' namespace be undefined if
> !defined(USE_ASH)?
This was a mistake and will be removed.

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/native_app_window_views.cc:336: return
shell_window_->window_type() == ShellWindow::WINDOW_TYPE_V1_PANEL;
On 2013/02/15 03:28:16, jeremya wrote:
> This class is getting pretty tangly :(
I wasn't in favor of doing the hack, but we decided it was important to support
v1 app panels... trying to compramise between tangly and mass code
duplication...

https://codereview.chromium.org/12212207/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/native_app_window_views.cc:360: return
shell_window_->window_type() == ShellWindow::WINDOW_TYPE_V1_PANEL;
On 2013/02/15 03:28:16, jeremya wrote:
> What does this do on Windows (or do we never create V1_PANEL types there?)

We won't create V1_PANEL on Windows. That scenario is complicated enough now
that we can have Ash + non ash windows on Win7/8.

[stevenjb, 2013-02-15 18:37:24]

+sky@ for owner

[sky, 2013-02-19 22:13:11]

LGTM

https://codereview.chromium.org/12212207/diff/5001/ash/wm/panel_frame_view.h
File ash/wm/panel_frame_view.h (right):

https://codereview.chromium.org/12212207/diff/5001/ash/wm/panel_frame_view.h#...
ash/wm/panel_frame_view.h:64: gfx::Font title_font_;
const

[flackr, 2013-02-19 23:53:04]

https://codereview.chromium.org/12212207/diff/5001/ash/wm/panel_frame_view.h
File ash/wm/panel_frame_view.h (right):

https://codereview.chromium.org/12212207/diff/5001/ash/wm/panel_frame_view.h#...
ash/wm/panel_frame_view.h:64: gfx::Font title_font_;
On 2013/02/19 22:13:12, sky wrote:
> const

Done.

[commit-bot: I haz the power, 2013-02-19 23:56:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12212207/16001

[commit-bot: I haz the power, 2013-02-20 02:02:38]

Change committed as 183369