chrome/browser/ui/extensions/shell_window.cc - Issue 12212207: Support panel titles and Icons for v1 apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 12212207: Support panel titles and Icons for v1 apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comment. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/shell_window.cc

diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc

index bd1e95070d2f62a57029956671503ef51398cbed..cf6a226b7b0a8de9ba5cfc71e7d6850122e3cfc3 100644

--- a/chrome/browser/ui/extensions/shell_window.cc

+++ b/chrome/browser/ui/extensions/shell_window.cc

@@ -164,7 +164,7 @@ void ShellWindow::Init(const GURL& url,

OnNativeWindowChanged();

if (!params.hidden) {

- if (params.window_type == WINDOW_TYPE_PANEL)

+ if (window_type_is_panel())

GetBaseWindow()->ShowInactive(); // Panels are not activated by default.

else

GetBaseWindow()->Show();