chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 12212207: Support panel titles and Icons for v1 apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 12212207: Support panel titles and Icons for v1 apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comment. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 44ec1dcc75a15d679fd69d1ee17264029b86c226..6e6bbc80efb49125f7ee90ce6ab276e0424665ee 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -598,7 +598,7 @@ bool WindowsCreateFunction::RunImpl() {

if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnablePanels) &&

PanelManager::ShouldUsePanels(extension_id)) {

ShellWindow::CreateParams create_params;

- create_params.window_type = ShellWindow::WINDOW_TYPE_PANEL;

+ create_params.window_type = ShellWindow::WINDOW_TYPE_V1_PANEL;

create_params.bounds = window_bounds;

create_params.minimum_size = window_bounds.size();

create_params.maximum_size = window_bounds.size();