Fail RTP parsing on excessive padding length.

Fail RTP parsing on excessive padding length.

BUG=webrtc:4771
R=stefan@webrtc.org

Committed: https://crrev.com/bd2522abf75891f34da6f83c247c47ca95641cee
Cr-Commit-Position: refs/heads/master@{#9525}

[pbos-webrtc, 2015-06-30 12:06:22]

PTAL. Also I couldn't find any place where RtpHeaderParser is unittested. Do you
know if there is one? I'd like to have this covered by tests and not only my
local fuzzer.

[pbos-webrtc, 2015-06-30 12:07:22]

make DCHECK

[stefan-webrtc, 2015-06-30 13:09:40]

lgtm

[pbos-webrtc, 2015-06-30 13:12:13]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-06-30 13:12:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220863002/20001

[commit-bot: I haz the power, 2015-06-30 13:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 13:23:49]

Try jobs failed on following builders:
  linux_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8155)

[pbos-webrtc, 2015-06-30 14:25:23]

remove padding bit from TruncatedPacketWithFBitSetEndingAfterFirstRedHeader

[pbos-webrtc, 2015-06-30 14:26:06]

The CQ bit was checked by pbos@webrtc.org

[pbos-webrtc, 2015-06-30 14:26:07]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1220863002/#ps40001 (title:
"remove padding bit from TruncatedPacketWithFBitSetEndingAfterFirstRedHeader")

[commit-bot: I haz the power, 2015-06-30 14:26:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220863002/40001

[commit-bot: I haz the power, 2015-06-30 14:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 14:43:55]

Exceeded global retry quota

[pbos-webrtc, 2015-06-30 15:30:47]

with size prints for tryjob

[pbos-webrtc, 2015-07-01 11:12:00]

lol bug

[pbos-webrtc, 2015-07-01 11:28:27]

fix rampup test and account for padding in RestoreOriginalPacket

[pbos-webrtc, 2015-07-01 11:28:49]

PTAL

[pbos-webrtc, 2015-07-01 11:28:57]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[pbos-webrtc, 2015-07-01 11:28:58]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1220863002/#ps100001 (title:
"fix rampup test and account for padding in RestoreOriginalPacket")

[commit-bot: I haz the power, 2015-07-01 11:29:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220863002/100001

[stefan-webrtc, 2015-07-01 11:38:17]

lgtm

https://codereview.webrtc.org/1220863002/diff/100001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc (right):

https://codereview.webrtc.org/1220863002/diff/100001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc:241: *packet_length -
header.paddingLength) {
Move header.paddingLength to other side of >

[pbos-webrtc, 2015-07-01 11:38:31]

move paddingLength to + side

[pbos-webrtc, 2015-07-01 11:38:56]

The CQ bit was checked by pbos@webrtc.org

[pbos-webrtc, 2015-07-01 11:38:56]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1220863002/#ps120001 (title:
"move paddingLength to + side")

[commit-bot: I haz the power, 2015-07-01 11:39:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220863002/120001

[commit-bot: I haz the power, 2015-07-01 12:35:57]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-07-01 12:36:06]

Patchset 7 (id:??) landed as
https://crrev.com/bd2522abf75891f34da6f83c247c47ca95641cee
Cr-Commit-Position: refs/heads/master@{#9525}