webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc - Issue 1220863002: Fail RTP parsing on excessive padding length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc

Issue 1220863002: Fail RTP parsing on excessive padding length. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: move paddingLength to + side Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc

index df3067ac6f3f83d367a6bcc43e64d9facbd20deb..8e2ff1742ef941ac975c07602bb95d9180f11f93 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc

@@ -237,7 +237,8 @@ bool RTPPayloadRegistry::RestoreOriginalPacket(uint8_t** restored_packet,

size_t* packet_length,

uint32_t original_ssrc,

const RTPHeader& header) const {

- if (kRtxHeaderSize + header.headerLength > *packet_length) {

+ if (kRtxHeaderSize + header.headerLength + header.paddingLength >

+ *packet_length) {

return false;

}

const uint8_t* rtx_header = packet + header.headerLength;