chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc - Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

===================================================================

--- chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc (revision 182296)

+++ chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc (working copy)

@@ -103,7 +103,7 @@

// testing. The requirements are that (1) it be a valid platform app, and (2)

// it contain no permissions dictionary.

std::string error;

- scoped_ptr<DictionaryValue> manifest(

+ scoped_ptr<base::DictionaryValue> manifest(

LoadManifest("init_valid_platform_app.json", &error));

std::vector<linked_ptr<DictionaryValue> > manifests;

@@ -112,9 +112,9 @@

const char* api_name = kPlatformAppExperimentalApis[i];

// DictionaryValue will take ownership of this ListValue.

- ListValue *permissions = new ListValue();

- permissions->Append(base::Value::CreateStringValue("experimental"));

- permissions->Append(base::Value::CreateStringValue(api_name));

+ base::ListValue *permissions = new base::ListValue();

+ permissions->Append(new base::StringValue("experimental"));

+ permissions->Append(new base::StringValue(api_name));

manifest->Set("permissions", permissions);

manifests.push_back(make_linked_ptr(manifest->DeepCopy()));

}