Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4688)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java

Issue 1220053004: [Feedback] Add connection type data to feedback reports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@change-test-types-for-feedback
Patch Set: Rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
index 8ef3494eba9e913d40da6bbd788cab0aee7acc58..e240a0429574d9d3e664473f0ae38fa2a3edf19e 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
@@ -15,6 +15,7 @@ import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.test.ChromeActivityTestCaseBase;
import org.chromium.content.browser.test.util.UiUtils;
+import org.chromium.net.ConnectionType;
import java.util.HashMap;
import java.util.Map;
@@ -331,7 +332,8 @@ public class FeedbackCollectorTest extends ChromeActivityTestCaseBase<ChromeActi
private static ConnectivityTask.FeedbackData createFeedbackData() {
Map<ConnectivityTask.Type, Integer> connections = new HashMap<>();
connections.put(ConnectivityTask.Type.CHROME_HTTPS, ConnectivityCheckResult.CONNECTED);
- return new ConnectivityTask.FeedbackData(connections, 10, 10);
+ return new ConnectivityTask.FeedbackData(
+ connections, 10, 10, ConnectionType.CONNECTION_3G, 4.2);
}
private static Bitmap createBitmap() {
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698