Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 12178026: Adds console renderer to merger backend. (Closed)

Created:
7 years, 10 months ago by agable
Modified:
7 years, 10 months ago
Reviewers:
M-A Ruel, hinoka
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

Adds console renderer to merger backend. This CL: a) creates a backend url that serves a merged console table (sans surroundings, javascript, announce header, and css). b) does some minor cleanup of the other backend code; c) changes tests to reflect slightly modified data storage formats; and d) still doesn't affect the current front-end. The next (and final, in this project) CL will: a) add pre-rendering and caching; and b) change the frontend to use this new renderer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=182044

Patch Set 1 #

Total comments: 2

Patch Set 2 : Responding to comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -186 lines) Patch
M app.py View 1 3 chunks +14 lines, -11 lines 0 comments Download
M merger.py View 1 6 chunks +130 lines, -48 lines 0 comments Download
A templates/merger_b.html View 1 chunk +117 lines, -0 lines 0 comments Download
M tests/test_console_merger/linux_row_input.txt View 2 chunks +6 lines, -14 lines 0 comments Download
M tests/test_console_merger/mac_row_input.txt View 2 chunks +6 lines, -12 lines 0 comments Download
M tests/test_console_merger/memory_row_input.txt View 2 chunks +6 lines, -14 lines 0 comments Download
M tests/test_console_merger/merged_console_output.html View 1 chunk +1 line, -3 lines 0 comments Download
M tests/test_console_merger/win_row_input.txt View 2 chunks +6 lines, -14 lines 0 comments Download
M tests/test_console_merger_splitrevs/linux_row_input.txt View 2 chunks +6 lines, -14 lines 0 comments Download
M tests/test_console_merger_splitrevs/mac_row_input.txt View 2 chunks +6 lines, -14 lines 0 comments Download
M tests/test_console_merger_splitrevs/merged_console_output.html View 4 chunks +4 lines, -8 lines 0 comments Download
M tests/test_parse_master/expected-comment.html View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/test_parse_master/expected-details.html View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/test_parse_master/expected-name.html View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/test_parse_master/expected-rev.html View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/test_parse_master/expected-status.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/test_parse_master_utf8/expected-comment.html View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/test_parse_master_utf8/expected-details.html View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/test_parse_master_utf8/expected-name.html View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/test_parse_master_utf8/expected-rev.html View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/test_parse_master_utf8/expected-status.html View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
agable
The main body of the change is in merger.py. Some minor parsing changes were made ...
7 years, 10 months ago (2013-02-04 21:55:03 UTC) #1
M-A Ruel
Partially-rubberstamped lgtm. https://chromiumcodereview.appspot.com/12178026/diff/1/app.py File app.py (right): https://chromiumcodereview.appspot.com/12178026/diff/1/app.py#newcode710 app.py:710: curr_row['comment'] = ''.join([unicode(tag).strip() for tag in No ...
7 years, 10 months ago (2013-02-08 02:16:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/12178026/6001
7 years, 10 months ago (2013-02-12 22:32:55 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 22:33:31 UTC) #4
Message was sent while issue was closed.
Change committed as 182044

Powered by Google App Engine
This is Rietveld 408576698