tests/test_parse_master_utf8/expected-comment.html - Issue 12178026: Adds console renderer to merger backend.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/test_parse_master_utf8/expected-comment.html

Issue 12178026: Adds console renderer to merger backend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/chromium-build

Patch Set: Responding to comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <tr>

2 <td colspan="6" class="DevComment ">

3 Add SpeechInputBubbleViews::notify_delegate_on_activation_change_, etc.<br />Ensure SpeechInputBubbleView continues observing its Widget as it's close d.<br />Needed so BubbleDelegateView::OnWidgetClosing will close the border widg et.<br /><br />Only notify the SpeechInputBubbleView's delegate when the act ivation changes through normal user interaction. The SpeechInputBubbleController deletes the SpeechInputBubbleImpl to close it explicitly, and then doesn't expect to be notified on that loss of focus/activation.<br /><br />BUG=98323,112 194<br />TEST=SpeechInputBubbles behave as expected.<br /><br />Review URL: http ://codereview.chromium.org/9370006 â	1 Add SpeechInputBubbleViews::notify_delegate_on_activation_change_, etc.<br />Ensure SpeechInputBubbleView continues observing its Widget as it's close d.<br />Needed so BubbleDelegateView::OnWidgetClosing will close the border widg et.<br /><br />Only notify the SpeechInputBubbleView's delegate when the act ivation changes through normal user interaction. The SpeechInputBubbleController deletes the SpeechInputBubbleImpl to close it explicitly, and then doesn't expect to be notified on that loss of focus/activation.<br /><br />BUG=98323,112 194<br />TEST=SpeechInputBubbles behave as expected.<br /><br />Review URL: http ://codereview.chromium.org/9370006 â

4 </td>

5 </tr>

OLD	NEW