tests/test_parse_master/expected-comment.html - Issue 12178026: Adds console renderer to merger backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/test_parse_master/expected-comment.html

Issue 12178026: Adds console renderer to merger backend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/chromium-build

Patch Set: Responding to comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/test_console_merger_splitrevs/merged_console_output.html ('k') | tests/test_parse_master/expected-details.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/test_parse_master/expected-comment.html

diff --git a/tests/test_parse_master/expected-comment.html b/tests/test_parse_master/expected-comment.html

index a1778f0f074d6cb8c5ebd541506db552df4c67f7..8bdf79640f2feeb160e02bae49a9e2dcc2f7add3 100644

--- a/tests/test_parse_master/expected-comment.html

+++ b/tests/test_parse_master/expected-comment.html

@@ -1,5 +1 @@

-<tr>

-<td colspan="6" class="DevComment ">

Add SpeechInputBubbleViews::notify_delegate_on_activation_change_, etc. Ensure SpeechInputBubbleView continues observing its Widget as it's closed. Needed so BubbleDelegateView::OnWidgetClosing will close the border widget. Only notify the SpeechInputBubbleView's delegate when the activation changes through normal user interaction. The SpeechInputBubbleController deletes the SpeechInputBubbleImpl to close it explicitly, and then doesn't expect to be notified on that loss of focus/activation. BUG=98323,112194 TEST=SpeechInputBubbles behave as expected. Review URL: http://codereview.chromium.org/9370006

- </td>

-</tr>

« no previous file with comments | « tests/test_console_merger_splitrevs/merged_console_output.html ('k') | tests/test_parse_master/expected-details.html » ('j') | no next file with comments »