Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: ui/views/bubble/bubble_border.h

Issue 12096084: Cleanup BubbleFrameView and BubbleBorder construction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Additional refactoring and cleanup. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc ('k') | ui/views/bubble/bubble_border.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_border.h
diff --git a/ui/views/bubble/bubble_border.h b/ui/views/bubble/bubble_border.h
index 6745278e76321b3ea6358239551979f54e0bcbab..78ba6cdcdb17e0dee8709acc44d027601737766a 100644
--- a/ui/views/bubble/bubble_border.h
+++ b/ui/views/bubble/bubble_border.h
@@ -65,7 +65,7 @@ class VIEWS_EXPORT BubbleBorder : public Border {
ALIGN_EDGE_TO_ANCHOR_EDGE
};
- BubbleBorder(ArrowLocation arrow_location, Shadow shadow);
+ BubbleBorder(ArrowLocation arrow, Shadow shadow, SkColor color);
sky 2013/01/31 19:31:16 Is there a compelling reason you're adding this? W
msw 2013/01/31 20:11:40 My thought was that hardcoded white is wrong, and
// Returns the radius of the corner of the border.
// TODO(xiyuan): Get rid of this since it's part of BorderImages now?
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc ('k') | ui/views/bubble/bubble_border.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698