Cleanup BubbleFrameView and BubbleBorder construction.

ui/views/bubble/bubble_border.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "ui/views/background.h"
@@ skipping 47 matching lines @@
   };
 
   // The position of the bubble in relation to the anchor.
   enum BubbleAlignment {
     // The tip of the arrow points to the middle of the anchor.
     ALIGN_ARROW_TO_MID_ANCHOR,
     // The edge nearest to the arrow is lined up with the edge of the anchor.
     ALIGN_EDGE_TO_ANCHOR_EDGE
   };
 
-  BubbleBorder(ArrowLocation arrow_location, Shadow shadow);
+  BubbleBorder(ArrowLocation arrow, Shadow shadow, SkColor color);

[sky, 2013/01/31 19:31:16]

Is there a compelling reason you're adding this? With the current approach it's
easy to get the right thing (white), but with the new approach folks have to
think about what color they should use and possibly get it wrong.

[msw, 2013/01/31 20:11:40]

My thought was that hardcoded white is wrong, and most/all bubbles should use
theme colors. Most/all bubble should use BubbleDelegateView, which makes it easy
to use theme colors (or override with a custom color). I hope to convert a few
outliers to BubbleDelegateView in followups; others should know their color.

 
   // Returns the radius of the corner of the border.
   // TODO(xiyuan): Get rid of this since it's part of BorderImages now?
   static int GetCornerRadius() {
     // We can't safely calculate a border radius by comparing the sizes of the
     // side and corner images, because either may have been extended in various
     // directions in order to do more subtle dropshadow fading or other effects.
     // So we hardcode the most accurate value.
     return 4;
   }
@@ skipping 139 matching lines @@
 
  private:
   BubbleBorder* border_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleBackground);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_