Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8026)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 12096084: Cleanup BubbleFrameView and BubbleBorder construction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Additional refactoring and cleanup. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
index d1d7b9bfcab0521b9fef4d482963ef93d16b4638..20e3d41a02de8a3f3fbe18fd661371132c1b5512 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
@@ -93,13 +93,9 @@ OmniboxPopupContentsView::OmniboxPopupContentsView(
result_bold_font_(result_font_.DeriveFont(0, gfx::Font::BOLD)),
ignore_mouse_drag_(false),
ALLOW_THIS_IN_INITIALIZER_LIST(size_animation_(this)) {
- // The following little dance is required because set_border() requires a
- // pointer to a non-const object.
- views::BubbleBorder* bubble_border =
- new views::BubbleBorder(views::BubbleBorder::NONE,
- views::BubbleBorder::NO_SHADOW);
- bubble_border_ = bubble_border;
- set_border(bubble_border);
+ bubble_border_ = new views::BubbleBorder(views::BubbleBorder::NONE,
+ views::BubbleBorder::NO_SHADOW, SK_ColorWHITE);
+ set_border(const_cast<views::BubbleBorder*>(bubble_border_));
// The contents is owned by the LocationBarView.
set_owned_by_client();
}

Powered by Google App Engine
This is Rietveld 408576698