Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 12095039: Add testing of generated (ARM) baseline decoders using hand-written decoders. (Closed)

Created:
7 years, 10 months ago by Karl
Modified:
7 years, 10 months ago
Reviewers:
JF
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add testing of generated (ARM) baseline decoders using hand-written decoders. This testing allows us to prove that the generate and hand-written decoders behave the same way (for the inputs that use the hand-written decoders). As a result, once tests pass, we can replace the corresponding hand-written decoders with the generated decoders. Note: This CL only compares baseline decoders in the data_processing_register ARM table. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3111 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10681

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+755 lines, -15 lines) Patch
M src/trusted/validator_arm/actual_vs_baseline.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/trusted/validator_arm/actual_vs_baseline.cc View 2 chunks +6 lines, -1 line 0 comments Download
A src/trusted/validator_arm/baseline_vs_baseline.h View 1 chunk +36 lines, -0 lines 0 comments Download
A src/trusted/validator_arm/baseline_vs_baseline.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/trusted/validator_arm/build.scons View 3 chunks +19 lines, -10 lines 0 comments Download
M src/trusted/validator_arm/dgen_test_output.py View 7 chunks +30 lines, -3 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_ARMv7_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_advanced_simd_data_processing_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_advanced_simd_element_or_structure_load_store_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_branch_branch_with_link_and_block_data_transfer_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_coprocessor_instructions_and_supervisor_call_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_data_processing_and_miscellaneous_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_data_processing_immediate_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_data_processing_register_shifted_register_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_data_processing_register_tests.cc View 2 chunks +591 lines, -0 lines 1 comment Download
M src/trusted/validator_arm/gen/arm32_decode_extension_register_load_store_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_extra_load_store_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_floating_point_data_processing_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_halfword_multiply_and_multiply_accumulate_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_load_store_word_and_unsigned_byte_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_media_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_memory_hints_advanced_simd_instructions_and_miscellaneous_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_miscellaneous_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_msr_immediate_and_hints_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_multiply_and_multiply_accumulate_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_named_classes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_other_floating_point_data_processing_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_packing_unpacking_saturation_and_reversal_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_parallel_addition_and_subtraction_signed_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_parallel_addition_and_subtraction_unsigned_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_saturating_addition_and_subtraction_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_signed_multiply_signed_and_unsigned_divide_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_simd_dp_1imm_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_simd_dp_2misc_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_simd_dp_2scalar_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_simd_dp_2shift_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_simd_dp_3diff_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_simd_dp_3same_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_synchronization_primitives_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_transfer_between_arm_core_and_extension_register_8_16_and_32_bit_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_transfer_between_arm_core_and_extension_registers_64_bit_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_unconditional_instructions_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator_arm/generate_decoder.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Karl
PTAL. Thanks. Note: All but one of the test files are only changed by the ...
7 years, 10 months ago (2013-01-29 20:54:06 UTC) #1
JF
7 years, 10 months ago (2013-01-29 22:37:20 UTC) #2
lgtm

lgtm assuming bots agree.

Powered by Google App Engine
This is Rietveld 408576698